Zugg Software :: View topic - Can an expert look at my work and see if i can improve it? THANKS! :)

Wanderer Joined: 14 Oct 2009 Posts: 57

Ok, Im rewriting my whole system. This thing is HUGE. And I doubt its the fastest way it could be. This is how it works...

I have a prompt trigger that runs on every prompt.. which calls an alias that does the following functions...

1. Check health/mana and sip accordingly.
2. Looks at poisons, and cures them using herb/smoke/potion.
3. Checks for defences and puts them up if needed.

So first of all the prompt has this code......

Wanderer Joined: 14 Oct 2009 Posts: 57

first big change that will hopefully be better. changed the bottom code to use #switch

Wizard Joined: 17 Jun 2006 Posts: 1201

Wanderer Joined: 14 Oct 2009 Posts: 57

hmmm, im not sure i get what you mean (sorry for my ignorance). Not used event for anything other the connect commands etc.

So would I put in my prompt #raiseevent onPrompt, then for each trigger i would call the event?

... eg if i get afflicted by yarl, it would then call the onprompt event and run my curing script?

do you have an example. i dont quite get how this works.

thanks!!

Wizard Joined: 22 Mar 2007 Posts: 2320

The event system works like this:

You create one or more Event objects named nameofevent. This is done either with the #EVENT command (like the #TRIGGER command) or in the Package Editor by specifying type Event instead of Trigger or Alias or something else. Inside the nameofevent you put in the code you want to be executed when the named event is raised.

A trigger (usually a trigger) fires and executes "#RAISEEVENT nameofevent". This will cause all events named nameofevent to be executed, in order by priority. You can add parameters to #RAISEEVENT -- "#RAISEVENT nameofevent 100" will cause nameofevent to be executed with %1 equal to 100.

The advantage of doing this is that you can separate different actions into different bits of code. Rather than having half a dozen triggers firing on your prompt (each one parsing the line from the mud, over and over), you can have just one trigger parse the prompt and fire #RAISEEVENT. If you ever change your prompt, you only need to modify the one trigger. Meanwhile, each individual event can do its own thing when it 'hears' that the event has been raised. Each event can be turned on or off with #T+ and #T-, like a trigger or alias. And you can write the code for each action (checking health, poisons, etc.) can be written in a separate event. You can have as many parameters in #RAISEEVENT as you need for your events.

Another way to handle this kind of thing is to your actions be Expression Triggers, which fire when a variable changes.

Wanderer Joined: 14 Oct 2009 Posts: 57

ok, i think i need to study this more. i dont understand how this is any better or different to just putting an alias in the prompt trigger, which contains the code. an event just seems to be the same as an alias so im not sure how moving the code from the alias into an event would change the speed of anything or make it work better. i already have an alias to perform each important action which are called as needed, just like i would with an event.

i think im just missing the point. read your posts multiple times, guess im gettin to old to understnad these things nowadays.

thanks again guys

Wizard Joined: 22 Mar 2007 Posts: 2320

You can certainly do it all in a single alias. The advantages of doing it as several events are (1) you can turn pieces of it on or off separately; (2) you can design it piece by piece, testing each piece separately without the danger of messing up all the rest of the alias code; (3) it makes it easy to add new pieces, simply by adding a new event; (4) it gives you practice with Cmud events. Basically, the efficiencies are mostly in the ability to write and modify the code. Since you already have working code, it's not a great advantage to convert it all to events. So for your purposes, it is probably not worth it, unless you want to play with events.

Wizard Joined: 17 Jun 2006 Posts: 1201

Wizard Joined: 17 Jun 2006 Posts: 1201

Wanderer Joined: 14 Oct 2009 Posts: 57

thanks for your post

thats basically how i do it now. except all the afflictions are inside a single @var and i use ismember.

anyone got any other ideas to speed things up? im going through my triggers and removing the naughty (*) at the start and putting ^ where possible.

thanks again everyone

adam