Zugg Software :: View topic

Apprentice Joined: 15 Jun 2010 Posts: 121

Some new rooms created are created with the room name set to the room description..... this is a weird one....don't know why this happened.. its not very repeatable

Posted: Thu Sep 02, 2010 2:34 am

Use the script debugger window with the raw input/output message to see exactly what the MUD is sending for those rooms. If the GMCP Room.Info.Name is blank, then the mapper might be trying to determine the name of the room from the description.

Wizard Joined: 17 Jun 2006 Posts: 1201

Because Brief only gives the room name and not a description. I saw you say yesterday somewhere description for room brief and was thinking that might happen. I know for certain that Room.Brief in ATCP only gave the room name.

Also this is something else that needs worked out by Achaea for example. If you do Config roomdesc brief or whatever it is in the game then it doesn't send the description at all. It only shows items in the room and the weather along with the name. Yet in the ATCP and GMCP? for brief you get the room name or at least that is what I always saw in the raw data. You have to turn on verbose to get the actual room description. This is why I was saying yesterday there should be a Room.Info.desc. When you map you only want the desc recorded in the description and not the weather or items or people in the room. Room.Info.desc would make that super easy to do. I'm not even sure why you would have a Room.Info.brief at all or Room.Brief in ATCP because no description is displayed when you have brief on.

Wizard Joined: 17 Jun 2006 Posts: 1201

Ah ha you said it in the version release notes!

Posted: Thu Sep 02, 2010 4:49 pm

Nope, you guys are right. I misunderstood what you were talking about with Brief. I thought it was a "brief description of the room". I didn't realize it was the same as the room name. In fact, why are they sending Brief at all if it's the same as the name??

I'll remove this from the next version. In fact, I'll change the code to look for Info.desc in case some MUD ever properly implements that in the future.

Wizard Joined: 17 Jun 2006 Posts: 1201

Right exactly! Why? It makes no sense. I even looked on Aardwolf and they are doing the same thing.

Aardwolf shows as an example:

Posted: Thu Sep 02, 2010 8:43 pm

Maybe what I will do is to use room.info.brief if no room.info.name is provided.

Keep in mind that the only thing "standard" about GMCP is the transport protocol. We never came to any real agreement about specific Messages. IRE just ported their ATCP messages over to GMCP, and then Aardwolf did something similar and then added their own tweaks. I agree that it would be nice if there was a better standard for some of the messages, but every MUD is a bit different and they all want to do things their own way. Coming to agreement is very difficult. We should be thankful it works as well as it does right now.

But thanks for the Aardwolf example. I haven't done much GMCP testing there and I didn't realize that they weren't sending the room.info.name value.

Apprentice Joined: 15 Jun 2010 Posts: 121

EDIT: nevermind I thought I fixed this but.. I still have this problem...
When I look in the debug window I see my #OK going through find and Loc being changed correctly, and then OnRoomEnter fires

However after this I see the Loc being changed AGAIN to the OLD ROOMs roomkey?? and then once it goes back to the old room it fires onroomcreate... I have no idea why the mapper is changing the Loc to the old room key after already setting the new one...

Posted: Tue Sep 21, 2010 7:18 pm

dbosst: Did you post to the wrong thread? I have no idea what you are talking about given the context of this thread. You'll need to give me a lot more information and examples of what you are talking about for me to help.

Apprentice Joined: 15 Jun 2010 Posts: 121

I was referring to the original post... where when I'm updating old rooms vnums, somtimes the map creates a new room for no reason even though there is an existing room.. and the room name assigned is the desc...

Normal results in Map mode, slow mode (one step) ( I know you said use safe but that doesn't work any better):

Posted: Tue Sep 21, 2010 10:13 pm

You should turn on the Raw Input/Output message in the Script Debugger to see where the GMCP data is sent from the MUD and what it contains. But it looks like CMUD is getting GMCP data for room #22419 and that is causing a new room to be created. But I'd need to see the additional data to tell for sure.

Also, I'd recommend trying to turn off as many of your scripts as possible to start debugging this and then turn them on one-by-one. It's possible something in one of your scripts is causing the location to change somehow. I'm not sure I really understand the line that has:

Apprentice Joined: 15 Jun 2010 Posts: 121

There is nothing that should be changing it though..

the ORE is just the OnRoomEnter event message I used for debugging:
#DEBUG ORE: %roomkey @room_name
where @room_name holds the room name set from %gmcp

Is there a way to debug the mapper more to figure out what's changing it? Even with everything in the debug window is being outputted I don't see anything that could change it there is no further script executions after the first OK/ on room enter

Posted: Wed Sep 22, 2010 1:07 am

Nope, turning on the "Show all script executions" and "Show variable changes" pretty much shows everything. Someday I plan to add more debug messages for the mapper too, but not something that's going to happen right now. As I said, just show the output with the Raw messages so I can see exactly where the GMCP data packets are coming in. Sometimes there are network packet breaks that might be causing issues.

Apprentice Joined: 15 Jun 2010 Posts: 121

like I said its pretty random, here is it with EVERYTHING enabled, I tried disabling as much as possible .. so this time I put all my gmcp info code inside a #IF (0) so it wouldn't execute.. so there are no other scripts that run before this room is created:

Posted: Wed Sep 22, 2010 7:41 pm

Yep, I can see the problem here. Notice that the GMCP data is sent in a different packet than the initial room name/description. So CMUD first sees the room name/description and this causes the normal non-GMCP code to process the text before it ever processes the GMCP data in the next packet. So this will be random and will completely depend upon where the network packet breaks are.

Can you check your map and confirm that the Room Key for the room "Wall of memories" is #22570 and that the vNum for this room is #9354 and that the "Real vNum" flag in the Room Properties is set?

Apprentice Joined: 15 Jun 2010 Posts: 121

keep in mind that I am doing my own room confirmation scripts..and so I have actually disabled the "USE VNUMS" option as well as any matching at all...

but when this happens the roomkey is the same as in the debug, the vnum is correct, but the MUD "real vnum" flag is NOT set

Posted: Wed Sep 22, 2010 9:48 pm

OK, I found where OnRoomCreate was actually being fired when a room was *updated* but not actually created. I've fixed this for the next version. What I can't figure out is where the RoomCreate occurred that set the wrong room name in the first place. Was the room name already screwed up before the dump that you gave above? I'm only seeing a single RoomCreate in that dump.

Apprentice Joined: 15 Jun 2010 Posts: 121

No in the LAST dump I posted that was for a brand NEW room created ... and the room name was perfectly fine in the gmcp info, as you can tell from debugging.. but this happens randomly in both instances of brand new rooms and rooms that already exist that need to be updated

but you can tell from the gmcp info it definitely had the name right in the gmcp.room.info.name ... but for some reason the mapper isn't processing it good

Posted: Wed Sep 22, 2010 11:41 pm

Yeah, but see, that is what doesn't make sense. The routine that is calling the OnRoomCreate sets the current room name to the gmcp.room.info.name right before it fires the event. So I can't see any way for this to be different from the gmcp data.

Is your GMCP trigger a "Prompt" or "newline" trigger? The map room is only defined for the "newline" GMCP trigger, so make sure you don't have the "Trigger on Prompt" set?

Posted: Wed Sep 22, 2010 11:55 pm

OK, nevermind, just wait for the next update. I fixed a couple of problems with Slow Walking and fixed the extraneous call to OnRoomCreate. I just tested a broken packet with the room data in a different packet from the GMCP data and couldn't get it to fail. So hopefully it is fixed. If not, I'm not sure what else to do.