Zugg Software :: View topic

Posted: Sun Mar 18, 2007 8:53 pm

Two small additions - you define the $abv local variable but then don't use it for anything. I assume you mean to change all the @abv references to $abv. Also, take a look at the online version of the #switch helpfile - it includes a second syntax for #switch that can reduce clutter when you're checking possible values of the same variable like you are in this example.

EDIT: Just spotted another thing in there, too. You use @abv= and @limb= to set the value of the two variables. You'll want to use only the variable names, abv= and limb= unless the variable is a local one.

Back on topic: custom functions in CMUD must be made up only of functions. If you wanted a function to return the full limb name when given an abbreviation, you could use %switch (no shorter syntax here I'm afraid :():

#fu limb($abv) {%switch($abv=a,abdomen,$abv=ra,right arm,...etc)}

Beginner Joined: 01 Mar 2007 Posts: 18

hehe funny @abv is suppuse to Be $adv what I did, I originaly created the switch for script for special comand and special target
so both variables were local $abv and $limb , then when I decided to modify to set a @limb for general targets just did a search and replace on $ to @ also the #if left over from other script

so custom funtions only funtions so would %var work assigning a value to a variable?

Beginner Joined: 01 Mar 2007 Posts: 18

Posted: Mon Mar 19, 2007 5:30 am

I guess you missed it the first time - you should be using varname=value rather than @varname=value. It's caused some scripts not to compile for some people. If you're trying to run a command from your function you should really be using %exec rather than %eval.

However, that might be moot. The way I had it originally, the function would return the name of the limb based on the abbreviation. So if you did:

#say @limb(a) @limb(rt)

then "abdomen right tusk" would be printed on the screen. Generally functions are used instead of commands because they can be used for many different things. If you wanted to recreate your alias above using the function I described, for example, you could just use this:

#var limb @setlimb(%1)

but the code is useful for more things than just setting the variable. I assumed that's what you wanted. If you just want the code to set the variable, you don't need to use functions at all, you can just have whatever script you're using run the alias that has the code you described in the first post. The code you posted in the post above this one won't return anything - you'd have to use it like this

#call @setlimb(%1)

which will be identical to just running the alias from the first post.

Beginner Joined: 01 Mar 2007 Posts: 18

Posted: Thu Mar 22, 2007 6:52 am

Yes, you need to use %exec to execute a command from inside a function. Since your original question was how to make the code more versatile, though, my suggestion is to do away with the limb= part and just have it return the value of the limb (see my example at the end of the first reply). Then if you want to set a variable based on the result you just do:

#var limb @setlimb(%1)

or whatever. If you have the function executing code and not returning any values its only use will be with #call like I already mentioned. For that you might as well use the alias you suggested in the very first post and not bother with functions at all, especially since I'd expect function call-switch function-exec function to be much slower than alias-switch command-command.

Posted: Thu Mar 22, 2007 6:36 pm

Your function has a typo in it. You need to put a ( right after the %switch call. Like this:

#FU setlimb($abv) {%switch($abv=cl, ...

It shouldn't even compile without that. Also, Fang is correct about the %exec call. I think you might be confusing functions and commands. A Function (using #FUNC and other functions like %switch) return a value. They don't perform any actions or commands. So you cannot use the assignment statement within a function like you are doing. So follow the advice that Fang gave above.