Zugg Software :: View topic

Wanderer Joined: 06 Dec 2004 Posts: 59

I have two databases, player.db and murder.db.

One stores player information (and does so quite well, thanks Xianfu). The other stores information about each playerkill.

The Triggers that put information into these databases all work perfectly.

Now I'm trying to figure out how to report the data from the murder.db to the players.

For example:

Wanderer Joined: 06 Dec 2004 Posts: 59

Wanderer Joined: 06 Dec 2004 Posts: 59

Wow.

46 views and no one can figure it out....

Glad I'm not the only one.

*edit: hmm...looks like it counts all views, not just unique ones...looks like those 46 (now 50) views might've been all mine...:(

Posted: Mon Feb 12, 2007 10:48 am

I had a look at it back when you first posted it, but you've done it in the most horridly unreadable way by making all the #ifs nested. Rewriting the whole thing to make it more readable would probably be faster. Once again, I'm wishing this was a CMUD script so you could just use #switch.

Wanderer Joined: 06 Dec 2004 Posts: 59

Yeah...the nested #IFs are horrendous....

I just checked out the cMud forums for the #SWITCH command/function, and yeah: it would be perfect for this and about a dozen other things I do in zMud. I'm waiting for the new Database module before I bother upgrading to cMud. :)

Back to the problem: I first tried a #CASE statement, but upon further investigation it didn't seem appropriate.

It's just that's there's so many things to check when the trigger fires, I couldn't find a better way to make it settle on the right data to report without the nested #IFs.

I have seen worse nested #IF on these forums though...:)

Any ideas?

Posted: Mon Feb 12, 2007 11:20 am

Well, because all the nine (twelve if you count one or more not existing) different states are unique, you can just have an #if for each. The expressions used for each #if get more complicated (#if (%ismember(@SubjectA,@listclans) AND %ismember(@SubjectB,@listclans) AND @SubjectA=@SubjectB) - hooray!) but the script as a whole gets easier to understand, especially if you have a comment before each explaining what it's checking for. Personally, I'd put the impetus on the player to define whether each subject is a clan/class/player and do away with the whole thing :P

Wanderer Joined: 06 Dec 2004 Posts: 59

The problem I see with doing individual #IF statements is that there's no check in place for players.

To explain (for example):

For Clan vs Clan I can do:

Posted: Mon Feb 12, 2007 11:54 am

Well, you already solved that problem yourself in the script above:

%numitems( %query( ((&Name = @SubjectA)), All)) > 0

will detect if the subject is a player.

EDIT: Though for speed you may want to only %query once and create a variable you can check instead.

Wanderer Joined: 06 Dec 2004 Posts: 59

-facepalm-

I was totally thinking about another problem when I wrote that. Hah.

While you're here, the other problem is:

In the player.db, with four fields (Name, Class, Clan, IP), given a player name: how would I do a query to find that player's class?

For example:

Posted: Mon Feb 12, 2007 12:31 pm

Hmm... I'm not sure how well this would work, having not tested it, but the %query command will spit out the player's record number, and then can't you use %db in conjunction with %dbget, like this:

PlayerRecNumber=%query( ((&Name = @SubjectA)), All)
PlayerClass=%db(%dbget(@PlayerRecNumber),Class)

Wanderer Joined: 06 Dec 2004 Posts: 59

Xianfu, everything seems to be working fine.

Thanx for all your help.

Merc