Zugg Software :: View topic

Wanderer Joined: 24 Aug 2012 Posts: 70

My Trigger is this...

#TRIGGER {^To the (%*), (%*), (%*)$}

My Test String is this...

To the north by northwest, several miles away, you see the Black Satin. She's heading South by Southwest, and is Anchored. Black Satin is lightly damaged.

My Results are this...

%1 :north by northwest, several miles away
%2 :you see the Black Satin. She's heading South by Southwest
%3 :and is Anchored. Black Satin is lightly damaged.

What I want to be getting is...

%1 :north by northwest
%2 :several miles away
%3 :you see the Black Satin. She's heading South by Southwest, and is Anchored. Black Satin is lightly damaged.

Any ideas on how to get the extra comma to default to the %3 instead of %1?

Wanderer Joined: 12 Feb 2003 Posts: 93 Location: USA

Is the fourth comma always going to be there? You could simply add a fourth (%*) and then concat the %3 and %4.
Or if there is always going to be a 'and is <someword>' You could incorporate that into your pattern. i.e. 'and is Anchored' 'and is Moored' 'and is at sea'

Though I do find that it is odd that it is matching it to the first. You would think the pattern matching would start at the beginning, vs the end of the line.

Wanderer Joined: 24 Aug 2012 Posts: 70

No. In fact, most of the trigger lines from the Mud will look like this...

To the south, far off in the distance, you sense a holy place touched by the Gods.

Giving the results of...

%1 :south
%2 :far off in the distance
%3 :you sense a holy place touched by the Gods.

Most trigger lines are having only two commas. This is just one of the few occasions that the trigger line decided to have 3 commas.

I mean, if I have to I can design a routine to deal with it, I just thought it could be dealt with in the trigger line as apposed to having to code a special routine. If I was to do that, I might as well just capture the whole line as one string and work it out manually.

I am definitely not going to split this occurrence into another trigger.

Posted: Wed Sep 19, 2012 6:33 am

First of all, not sure why you're using (%*). The %* isn't really a pattern-matching variable. It should be (*).

Second, the reason why it's matching so many is because (*) is greedy, and it'll match everything until the other two "matches" are met. For instance, if you had the following line:

Posted: Wed Sep 19, 2012 6:33 am

It can be done with regexp,

#REGEX {^To the (.+?), (.+?), (.*)$} { do_blah }

Wanderer Joined: 12 Feb 2003 Posts: 93 Location: USA

Also.. out of curiosity.. what MUD is this? An Oceangoing MUD sounds rather neat

Wizard Joined: 22 Mar 2007 Posts: 2320

Try simply getting rid of the $ at the end of the Zscript trigger:
#TRIGGER {^To the (*), (*), (*)}

Wanderer Joined: 12 Feb 2003 Posts: 93 Location: USA

That won't solve his issue sir. The results are still the same for me duplicating his trigger and test phrase. On 2.37

Wanderer Joined: 24 Aug 2012 Posts: 70

Thanks. I'm not a big Perl enthusiast. Not that I have anything against it, just haven't gotten to using it much. I see that I will have to change that.

That worked well.

This is Medievia. It has grown to encompass ocean activities like harvesting Fae Crabs and trying to keep your ship from being destroyed by mobs ranging from Sea Serpents to Termites.

Wanderer Joined: 24 Aug 2012 Posts: 70

Perhaps I spoke too soon. I had the first #REGEX start doing the same with

To the north, not far from here, you see a village with a bell tower and a lighthouse, adjacent to a bustling trade post.

I then moved to Rehabs suggestion and not a fix.

I then went to ins0mnia's suggestion and that seems to be holding. I will have to wait and run a few test to see if it hold.

Thanks Guys. The prompt solution will be the easiest to solve this if I can get it too hold.

Wizard Joined: 22 Mar 2007 Posts: 2320

If the first regex started doing the same, then the second regex will too, because it is even less specific.

Try this regex:

Posted: Wed Sep 19, 2012 7:35 pm

Mine works fine because the ? are inside the parens. Notice the ? don't do anything outside the parens because the block is already being matched to where it won't include commas. Either way works, but it's redundant to do both.

GURU Joined: 23 Dec 2000 Posts: 4834 Location: USA

Sorcerer Joined: 15 Apr 2011 Posts: 809

Matching the broadest width possible is what being greedy means :P

Wanderer Joined: 24 Aug 2012 Posts: 70

Well, after sever testing, it seems to be fine. Thanks for the help here.