Zugg Software :: View topic

Newbie Joined: 23 Jul 2004 Posts: 3

Someone gave me this code so long ago I forgot who it was. Although it does what I want it do zMud gives it a sytax error. The code modifies my prompt so that it displays my max of health, mana, and moves, plus it gives different colors when I am low on health and an incredibly annoying sound to make sure I pay attention. It uses my score output to update the maxes as far as I know. Also this allows the prompt to track and update other parts of the script, mainly for hunting and avoiding.

First I have zMud version 7.05
Here is what the mud displays normally:

<232hp 368m 275mv>

Now here is the erroneous code, I would greatly appreciate it if anyone could see what is done wrong perhaps it is affecting me and I just don't realize it. Thankyou in advance! Now here it is:

hp = %1;m = %2;mv = %3;#MATH dhp @maxhp*25/100;#MATH dm @maxm*25/100;#MATH dmv @maxmv*25/100;#IF ((@dhp>=@hp) and (@alarm=0)) {#IF @sounds {#PLAY warning.wav}};#IF (@dhp<@hp) {alarm=0} {alarm=1};#MATH checkstats (%len(%left(@primary,1))+%len(%left(@secondary,1))+%len(%left(@shield,1))+%len(%left(@held,1)));#SUBSTITUTE %ansi(9)(%ansi(%if(@dhp>=@hp,12,cyan))%1%ansi(9)/%ansi(%if(@dhp>=@hp,12,cyan))@maxhp%ansi(9)hp %ansi(%if(@dm>=@m,12,cyan))%2%ansi(9)/%ansi(%if(@dm>=@m,12,cyan))@maxm%ansi(9)m %ansi(%if(@dmv>=@mv,12,cyan))%3%ansi(9)/%ansi(%if(@dmv>=@mv,12,cyan))@maxmv%ansi(9)"mv")%if(@checkstats>2,%ansi(12)" **FIX YOUR STATS**",);#IF @mirrorscheck {mirrorshere=@mirrorsheretemp;mirrorsheretemp=0;mirrorscheck=0} {#ADD mirrorshere @mirrorsheretemp;mirrorsheretemp=0};#IF ((@sneakflee) AND (@track="yes")) {scan all} {#IF ((@ihavefled) AND (@fleeback)) {scan all}};sneakflee=0;ihavefled=0

SubAdmin Joined: 18 Nov 2001 Posts: 5182

The code looks to be very solid. I would suggest 2 small changes.
"#IF @mirrorscheck {" should be "#IF (@mirrorscheck) {"
'#SUBSTITUTE %ansi(9)....' should be '#SUBSTITUTE {%ansi(9)....}'
Neither change really seems necessary; they are more meant for clarity. zMud uses 2 different parsing methods on scripts. One is slow and thorough, it is used for the syntax checker. The other is fast and used to actually preform the script. The syntax checker occasionally sees things it doesn't like, but they are perfectly fine. Such errors in the syntax checker are generally low priority bugs.

Magician Joined: 23 Apr 2003 Posts: 358 Location: USA

Playing with this code, it's just giving a syntax error because there's a space in front of %ansi, which isn't really a syntax error (it's an error in the syntax checker), and so far as I can tell, it should work well.

My suggestion to make it look a lot nicer, and easier to track errors is to create a function to determine the colors:

Newbie Joined: 23 Jul 2004 Posts: 3

Awesome, thankyou Vijilante those two fixes made the syntax checker go away and put it in all pretty print which makes it easier for me to understand and try to learn from. Since I didn't write this I was always puzzled how this worked and working through that whole mess usually got me more confused, seeing as the help files aren't very detailed. Also, I noticed the part that I squiggly-braketed right after #SUBSTITUTE, is not in the pretty print wasn't sure if that is how inherit functions display or not:

{%ansi(9)(%ansi(%if(@dhp>=@hp,12,cyan))%1%ansi(9)/%ansi(%if(@dhp>=@hp,12,cyan))@maxhp%ansi(9)hp %ansi(%if(@dm>=@m,12,cyan))%2%ansi(9)/%ansi(%if(@dm>=@m,12,cyan))@maxm%ansi(9)m %ansi(%if(@dmv>=@mv,12,cyan))%3%ansi(9)/%ansi(%if(@dmv>=@mv,12,cyan))@maxmv%ansi(9)"mv")%if(@checkstats>2,%ansi(12)" **FIX YOUR STATS**",)}

geniusclown, the code you wrote, is that for a new trigger altogether that seperately marks the colors inside the script or does it add on to the already existing trigger. I am not very familiar with the way %ansi works or most % functions. So be gentle in your explaination Wink

.

Thankyou

Magician Joined: 23 Apr 2003 Posts: 358 Location: USA

When you run across a new function or command, it's always a good idea to look it up in zMUD's help docs, which are wonderfully detailed and well cross-referenced.

You know that commands execute stuff, and always start with a #. Functions can occur just about anywhere within commands, and rather than doing something, it outputs something. You can think of functions as being variables (starting with @), but instead of being static (whatever's stored in them), their values depend on the input. Compare these two scenarios, one using #IF command, the other using %if function, both producing identical output:

Newbie Joined: 23 Jul 2004 Posts: 3

Ah ok that helped a lot more than the help file did, I learn by examples best, sometimes exclusively.

There is a little discrepancy with the suggestion for improving my prompt cause as is it makes the colors based on a comparison between two unrelated variables, namely my hp and my mana but I believe I can work on it and fix it myself. Get some practice in as well to make this stick. Thankyou both so much again.